Expanding static memory DMA offset feature#191
Merged
Conversation
JacobBarthelmeh
force-pushed
the
staticmemory_2
branch
3 times, most recently
from
September 26, 2025 22:35
1c2293d to
53d7586
Compare
JacobBarthelmeh
marked this pull request as ready for review
September 26, 2025 22:39
bigbrett
requested changes
Oct 7, 2025
bigbrett
left a comment
bigbrett
left a comment
Contributor
There was a problem hiding this comment.
Great additions, I think there might be a few tweaks/bugs
Contributor
Author
|
rebasing onto main to resolve merge conflicts |
JacobBarthelmeh
force-pushed
the
staticmemory_2
branch
2 times, most recently
from
October 17, 2025 21:16
5cd1285 to
14ebc6c
Compare
bigbrett
requested changes
Oct 29, 2025
bigbrett
left a comment
bigbrett
left a comment
Contributor
There was a problem hiding this comment.
Nice work Jacob, a few more tweaks I noticed just for consistency. Also please resolve merge conflicts
fix for hash dma additions mldsa using DMA offset feature remove unused flag and add malloc to cmac benchmark add macro guards around DMA additions fix typo for state address with cmac run git-clang-format
JacobBarthelmeh
force-pushed
the
staticmemory_2
branch
from
October 29, 2025 21:27
14ebc6c to
1498e23
Compare
JacobBarthelmeh
assigned
JacobBarthelmeh and
bigbrett and unassigned
bigbrett and
JacobBarthelmeh
bigbrett
requested changes
Oct 31, 2025
bigbrett
requested changes
Oct 31, 2025
bigbrett
self-requested a review
November 3, 2025 16:37
bigbrett
approved these changes
Nov 3, 2025
jackctj117
pushed a commit
that referenced
this pull request
Nov 3, 2025
* add cmac and start of other hash algos fix for hash dma additions mldsa using DMA offset feature remove unused flag and add malloc to cmac benchmark add macro guards around DMA additions fix typo for state address with cmac run git-clang-format * add return value checks, free in benchmark buffer on error, add macro guards * fix typo and add fix return value checks * fix flag for read/write with DMA operations
billphipps
pushed a commit
to billphipps/wolfHSM
that referenced
this pull request
Nov 3, 2025
* add cmac and start of other hash algos fix for hash dma additions mldsa using DMA offset feature remove unused flag and add malloc to cmac benchmark add macro guards around DMA additions fix typo for state address with cmac run git-clang-format * add return value checks, free in benchmark buffer on error, add macro guards * fix typo and add fix return value checks * fix flag for read/write with DMA operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of static memory DMA with: